RFR: 8067306: Improve STATIC_ASSERT

Kim Barrett kim.barrett at oracle.com
Fri Jan 9 16:48:58 UTC 2015


On Jan 9, 2015, at 4:00 AM, Erik Helin <erik.helin at oracle.com> wrote:
> 
> On 2015-01-08, Kim Barrett wrote:
>> On Jan 7, 2015, at 7:25 AM, Stefan Karlsson <stefan.karlsson at oracle.com> wrote:
>>> 
>>> I'll sponsor and review the patch if you change "(Cond) ? true : false" to just "(Cond)". Any potential problems with ancient compilers can be dealt with when / if they are causing problems.
>> 
>> 
>> CR: https://bugs.openjdk.java.net/browse/JDK-8067306
>> New full webrev: http://cr.openjdk.java.net/~kbarrett/8067306/webrev.03/
>> Incremental webrev: http://cr.openjdk.java.net/~kbarrett/8067306/webrev.03.incr/
> 
> Still good, Reviewed.
> 
> Thanks,
> Erik

Erik & Stefan, thanks for your reviews.

Stefan, thanks for your offer of sponsorship.  I’m doing final testing with an up to date repository.  I’ll send you an hg export once that’s done.



More information about the hotspot-runtime-dev mailing list