RFR 8054494: Remove sun.misc.Unsafe.monitorEnter, monitorExit and tryMonitorEnter
Filipp Zhinkin
filipp.zhinkin at gmail.com
Thu Jan 15 08:12:01 UTC 2015
Hi David,
On Wed, Jan 14, 2015 at 10:38 AM, David Holmes <david.holmes at oracle.com> wrote:
> Hi Paul,
>
>
> On 13/01/2015 11:18 PM, Paul Sandoz wrote:
>>
>> Here is a second revision that avoids adding the monitor methods to
>> WhiteBox:
>>
>>
>> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8054494-dev-unsafe-monitor-remove/webrev/
>>
>> I investigated changing ProcessBuilder/Basic.java to use
>> WhiteBox.isMonitorInflated (with some judicious jtreg annotations and
>> placing things on the boot classpath). However the peculiarities of when
>> monitor inflation occurs seem to make using this unreliable so i left this
>> test as is.
>
>
> Ok. Changes seem fine - and nice not to have to move this stuff to WB.
>
> Must confess I don't understand why the BusyLock test was using tryEnter in
> the first place :)
To be honest, I can't remember why it was implemented so. :)
> I assume it passes/fails when expected using RTM?
Personally I can't check it, but there are no changes in test logic:
one thread is still trying to enter a monitor that is already owned by
other thread.
Regards,
Filipp.
>
> Thanks,
> David
>
>> Paul.
>>
>
More information about the hotspot-runtime-dev
mailing list