RFR(M): 8069207 - [TESTBUG] Exception thrown for java.lang.NoSuchMethodError: sun.misc.Unsafe.monitorExit

[David Holmes]

Hi Christian,

On 17/01/2015 4:40 AM, Christian Tornqvist wrote:
> Hi everyone,
>
> Please review this change adding tests for sun.misc.Unsafe, it's a rewrite
> of some internal tests that were written for another test framework. The
> change includes removing the tests for monitorEnter/Exit.

Without comparing to the existing tests these look okay - pretty basic 
API functional checks. But there seem to be a number missing (eg 
reallocateMemory, staticFieldOffset, objectFieldOffset, and others) - I 
assume the omission of tests for the deprecated methods is deliberate?

One meta-question (as usual) - don't you need to ensure the testlibrary 
code is built if you are going to use it?

Some indentation/layout issues:

test/runtime/Unsafe/GetPutBoolean.java

Looks like spurious tab/indent at line 46.

test/runtime/Unsafe/GetPut<primitive>.java

Ditto line 51 in all files

test/runtime/Unsafe/GetPutObject.java

Indentation issues at: 39, 45 and 48

test/runtime/Unsafe/GetUnsafe.java

Indentation wrong for all of main().

test/runtime/Unsafe/PageSize.java

Indentation all over the place

test/runtime/Unsafe/SetMemory.java

Indentation wrong

test/runtime/Unsafe/ThrowException.java

Indentation wrong.

Thanks,
David

>
>
> The tests have been verified to work on all our major platforms (using
> JPRT).
>
>
>
> Webrev:
>
> http://cr.openjdk.java.net/~ctornqvi/webrev/8069207/webrev.00/
>
>
>
> Bug (unfortunately not visible):
>
> https://bugs.openjdk.java.net/browse/JDK-8069207
>
>
>
> Thanks,
>
> Christian
>