RFR(XS): JDK-8068655 frame::safe_for_sender() computes incorrect sender_sp value for interpreted frames

Daniel D. Daugherty daniel.daugherty at oracle.com
Mon Jan 26 18:24:41 UTC 2015

On 1/26/15 7:40 AM, Frederic Parain wrote:
> Greetings,
> Please review this small fix in the frame verification code.
> The bug report includes a detailed description of the issue.
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8068655
> Webrev:
> http://cr.openjdk.java.net/~fparain/8068655/webrev.00/

     I like that sender_sp, sender_pc, and saved_fp are now declared
     together and set together. Much more clean.

Thumbs up.


It does seem a little strange that the 'link_offset' enum is
defined in a section of src/cpu/x86/vm/frame_x86.hpp that is
commented as "C++ interpreter".

> Thanks,
> Fred

More information about the hotspot-runtime-dev mailing list