RFR(XS): JDK-8068655 frame::safe_for_sender() computes incorrect sender_sp value for interpreted frames

[Frederic Parain]

Thank you Dan and Coleen for the reviews.

To Dan:
The "C++ interpreter" comment is misleading, in fact it marks
the end of a comment block related to the C++ interpreter.
The enum is preceded by two big comment blocks, one describing
the frame format of the template interpreter, and one describing
the frame format of the C++ interpreter.

Regards,

Fred

On 26/01/2015 19:24, Daniel D. Daugherty wrote:
> On 1/26/15 7:40 AM, Frederic Parain wrote:
>> Greetings,
>>
>> Please review this small fix in the frame verification code.
>> The bug report includes a detailed description of the issue.
>>
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8068655
>>
>> Webrev:
>> http://cr.openjdk.java.net/~fparain/8068655/webrev.00/
>
> src/cpu/x86/vm/frame_x86.cpp
>      I like that sender_sp, sender_pc, and saved_fp are now declared
>      together and set together. Much more clean.
>
> Thumbs up.
>
> Dan
>
> P.S.
> It does seem a little strange that the 'link_offset' enum is
> defined in a section of src/cpu/x86/vm/frame_x86.hpp that is
> commented as "C++ interpreter".
>
>
>>
>> Thanks,
>>
>> Fred
>>
>

-- 
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: Frederic.Parain at oracle.com