RFR: 8049632: JDK 1.8.0 b132 :Linux x64 : Crash in ClassFileParser::copy_localvariable_table(..)

[Keith McGuigan]

I'm glad to see it getting some use! :)

On Wed, Jan 28, 2015 at 12:12 PM, Coleen Phillimore <
coleen.phillimore at oracle.com> wrote:

>
> On 1/28/15, 12:08 PM, Coleen Phillimore wrote:
>
>>
>> On 1/28/15, 11:26 AM, Keith McGuigan wrote:
>>
>>> Looks good to me.
>>>
>>
>> Thanks Keith!  You were the one who told me about these extra hashtable
>> implementations.
>>
> ... and added ResourceHashtable.
>
> coleen
>
>  Coleen
>>
>>
>>> On Wed, Jan 28, 2015 at 11:11 AM, Coleen Phillimore <
>>> coleen.phillimore at oracle.com <mailto:coleen.phillimore at oracle.com>>
>>> wrote:
>>>
>>>     Summary: Use resource allocated hashtable for local variable table
>>>     checking
>>>
>>>     I was never able to reproduce this after considerable time trying.
>>>     I also never found anything wrong with the code that would cause
>>>     an extra or incorrect os::free call.  This change checks LVT
>>>     entries using the existing ResourceHashtable rather than a ad-hoc
>>>     extra hashtable definition in classFileParser.cpp.  So this change
>>>     removes the os::free call.  I think whatever caused the original
>>>     bug will crash somewhere else now, and hopefully be easier to find.
>>>
>>>     Tested with jck9, jck1.4 runThese tests, nsk and jtreg tests, and
>>>     added test.
>>>
>>>     open webrev at http://cr.openjdk.java.net/~coleenp/8049632/
>>>     <http://cr.openjdk.java.net/%7Ecoleenp/8049632/>
>>>     bug link https://bugs.openjdk.java.net/browse/JDK-8049632
>>>
>>>     Thanks,
>>>     Coleen
>>>
>>>
>>>
>>>
>>> --
>>>
>>> twitter-icon-large.png
>>>
>>>
>>>
>>> Keith McGuigan
>>>
>>> @kamggg
>>>
>>> kmcguigan at twitter.com <mailto:kmcguigan at twitter.com>
>>>
>>>
>>
>


-- 

[image: twitter-icon-large.png]

Keith McGuigan

@kamggg

kmcguigan at twitter.com