RFR(XS) 8130183: InnerClasses: VM permits wrong inner_class_info_index value of zero

harold seigel harold.seigel at oracle.com
Wed Jul 8 12:55:21 UTC 2015


Thanks for the review!

Harold
On 7/8/2015 8:53 AM, Lois Foltan wrote:
> Looks good.
> Lois
>
> On 7/8/2015 8:16 AM, harold seigel wrote:
>> Hi,
>>
>> Please review this small change to fix bug JDK-8130183.  The JVM 
>> allows the InnerClasses attributes inner_class_info_index to have the 
>> value of zero.  This violates JVM-Spec 8.  See 
>> http://docs.oracle.com/javase/specs/jvms/se8/html/jvms-4.html#jvms-4.7.6.
>>
>> The fix ensures that the inner_class_info_index is non-zero and is a 
>> valid index into the constant pool.
>>
>> Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8130183/
>>
>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8130183
>>
>> The fix was tested with JCL Lang and VM tests, the UTE quick and 
>> split_verifier tests, and the hotspot, java/io, java/lang, and 
>> java/util JTreg tests.
>>
>> Thanks, Harold
>



More information about the hotspot-runtime-dev mailing list