Open code review for 8061999 Enhance VM option parsing to allow options to be specified
David Holmes
david.holmes at oracle.com
Thu Jul 9 11:14:48 UTC 2015
On 9/07/2015 8:55 PM, Dmitry Dmitriev wrote:
> Hello David,
>
> I think that it look like same limitations which was applied to the
> options in environment variables before JDK-8074895
> <https://bugs.openjdk.java.net/browse/JDK-8074895> fix. I think Ron can
> add more information about that.
You can't read an environment variable line-by-line so we have to have
fixed buffer. A file can be read line-by-line.
Cheers,
David
> Thanks,
> Dmitry
>
> On 09.07.2015 8:06, David Holmes wrote:
>> <trimming>
>>
>> On 9/07/2015 6:29 AM, Dmitry Dmitriev wrote:
>>> On 08.07.2015 22:26, Karen Kinnear wrote:
>>>> 2) is there a maximum length to the options read in from the file?
>>> The current implemented limitations are following: only one VM option
>>> file can be specified, maximum size of the file is 1024 bytes, up to 64
>>> VM options
>>
>> That seems extremely limiting. Why should there be a maximum size, why
>> can't you just read the file line by line and keep processing until it
>> is all read ??
>>
>> Thanks,
>> David
>
More information about the hotspot-runtime-dev
mailing list