RFR: 8087342: crash in klassItable_initialize_itable_for_interface

[Karen Kinnear]

David,

Thank you for the review. And yes, your summary is cleaner and less wordy than mine :-)

thanks,
Karen

On Jul 15, 2015, at 8:08 PM, David Holmes wrote:

> Hi Karen,
> 
> On 16/07/2015 2:40 AM, Karen Kinnear wrote:
>> 
>> Please review for JDK9:
>> 
>> bug: https://bugs.openjdk.java.net/browse/JDK-8087342
>> webrev: http://cr.openjdk.java.net/~acorn/8087342.2/webrev/
>> 
>> Crash occurs in product when we should through IncompatibleClassChangeError.
> 
> Based on the description in the bug report and copious amount of rewritten comments, these changes seem quite reasonable - though I can't claim to be an expert in the details here. Bottom line is we need to skip private interface methods when checking other aspects.
> 
> Thanks,
> David
> 
>> testing:
>> internal tests: Defmeth (updated), SelectionResolution - product and fastdebug
>> jprt
>> jck
>> jtreg/hotspot_all
>> jtreg/jdk_streams
>> test,noncolo.testlist, -atk quick
>> 
>> (jck and macosx testing in progress)
>> 
>> thanks,
>> Karen
>>