RFR(XS) 8129895: New verifier fails to reject erroneous cast from int[] to other arrays of small integer types

harold seigel harold.seigel at oracle.com
Mon Jul 20 19:11:31 UTC 2015


Hi George,

Thanks for the review!

Harold

On 7/20/2015 2:56 PM, George Triantafillou wrote:
> Hi Harold,
>
> This looks good.
>
> -George
>
> On 7/20/2015 2:29 PM, harold seigel wrote:
>> Hi,
>>
>> Please review this small change to fix bug 8129895.  The split 
>> verifier erroneously allows arrays of primitive ints to be assignable 
>> to arrays of Booleans, bytes, chars, and shorts. This fix adds a new 
>> function (is_component_assignable_from()) for explicitly checking 
>> assign-ability of array components.  The new function requires that 
>> primitive array components be identical for assign-ability.
>>
>> Open webrev: http://cr.openjdk.java.net/~hseigel/bug_8129895/
>>
>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8129895
>>
>> The fix was tested with JCK Lang and VM tests, the UTE quick and 
>> split verifier tests, and the hotspot, and JDK vm, java/io, 
>> java/lang, and java/util JTreg tests.
>>
>> Thanks, Harold
>



More information about the hotspot-runtime-dev mailing list