RFR(XS) 8081695: Old verifier fails to reject bad access to protected <init> method

harold seigel harold.seigel at oracle.com
Fri Jul 24 13:52:35 UTC 2015


Hi Coleen,

Thanks for the review.

Harold

On 7/24/2015 9:50 AM, Coleen Phillimore wrote:
>
> Harold,
>
> I don't know if this is still out for review, but it looks fine.
>
> We'll soon find out whose old bytecodes motivated this fix in the 
> first place.
>
> Good luck,
> Coleen
>
> On 7/17/15 10:48 AM, harold seigel wrote:
>> Hi,
>>
>> Please review this small change to fix bug JDK-8081695.  The (old) 
>> type inferencing verifier excluded a particular protected access 
>> check for invokespecial calls of protected methods.  That exclusion 
>> was done because of bytecodes generated by very old broken 
>> compilers.  It is being removed because it violates the JVM-8 Spec 
>> and should no longer be needed.
>>
>> Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8081695/
>>
>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8081695
>>
>> The fix was tested with JCK Lang and VM tests, WLS sanity testing, 
>> the UTE quick tests, and the hotspot, and JDK vm, java/io, java/lang, 
>> and java/util JTreg tests.
>>
>> Thanks, Harold
>



More information about the hotspot-runtime-dev mailing list