RFR (s) 8085865: hs_err improvement: Printing /proc/cpuinfo makes too long hs_err files

[Coleen Phillimore]

Thank you for the code review and comments.

On 6/17/15 10:20 AM, Daniel D. Daugherty wrote:
> On 6/17/15 8:04 AM, Coleen Phillimore wrote:
>> Okay, thank you for the nicely worded comment.
>> Coleen
>>
>> On 6/17/15 10:01 AM, Daniel D. Daugherty wrote:
>>> // Print the first "model name" line and the first "flags" line
>>> // that we find and nothing more. We assume "model name" comes
>>> // before "flags" so if we find a second "model name", then the
>>> // "flags" field is considered missing.
>>
>
> No problem. I've been writing a lot lately about biased locking :-)
> It's a pleasure to write a comment for something else.
>
> I'm surprised you didn't use the webrev that has the "next" links... :-)
>
> > http://cr.openjdk.java.net/~coleenp/8085865.03/
>
> src/os/aix/vm/os_aix.cpp
>     No comments.
>
> src/os/bsd/vm/os_bsd.cpp
>     No comments.
>
> src/os/linux/vm/os_linux.cpp
>     L2220:   // Other platforms have reasonable cpuinfo files
>         Perhaps "less repetitious" instead of "reasonable"?
>
>     L2222:   if (fp) {
>         This should be "(fp != NULL)". No implied booleans.
>
>     L2224:       if (fgets(buf, buflen, fp)) {
>         This should be "(fgets(...) != NULL)". No implied booleans.
>
>     L2234:             return true;
>     L2240:           return true;
>     L2243:     }
>         You need an "fclose(fp);" above each of these lines.
>
You are right.  I will add the fclose(fp).  Thank you for noticing 
that.  I will also change "reasonable" to repetitive.

Coleen
> src/os/solaris/vm/os_solaris.cpp
>     No comments.
>
> src/os/windows/vm/os_windows.cpp
>     No comments.
>
> src/share/vm/runtime/os.cpp
>     No comments.
>
> src/share/vm/runtime/os.hpp
>     No comments.
>
> src/share/vm/runtime/vm_version.cpp
>     No comments.
>
> src/share/vm/utilities/vmError.cpp
>     No comments.
>
>
> Dan
>
>