RFR(XS): 8098815: Assertion failure in CDS shared string archive support on Windows

[Coleen Phillimore]

When can string_ranges be non-null but num_ranges = 0?  I thought they 
are initialized together in map_string_regions?

Please add a comment for this situation.

Also, can you add the static keyword before num_ranges and string_ranges 
so at least the names don't escape.

Thanks,
Coleen

On 6/17/15 10:52 AM, Tom Benson wrote:
> Hi,
> Please review this change for JDK-8098815.  The CDS code which maps 
> the shared strings from an archive file must check for a zero length 
> before calling the G1 fill_archive_regions routine.  It already checks 
> this before the earlier calls to check_archive_address and 
> alloc_archive_regions, for which fill_archive_regions is the final 
> step. The problem occurred only on Windows because the string table is 
> not included in the archive there.
>
> JBS:   https://bugs.openjdk.java.net/browse/JDK-8098815
> Webrev: http://cr.openjdk.java.net/~tbenson/8098815/webrev.00/
> Tested: JPRT
>
> Thanks,
> Tom
>