RFR(XS): 8098815: Assertion failure in CDS shared string archive support on Windows

[Tom Benson]

Hi,

On 6/17/2015 1:44 PM, Coleen Phillimore wrote:
>
> I think someone tested this on windows already (Tom please confirm) 
> and given the urgency and low risk of this fix, I don't think we 
> should wait for a full test run.

I'm still waiting for a windows-only RBT run of the tests.
Tom
>
> thanks,
> Coleen
>
> On 6/17/15 12:54 PM, Daniel D. Daugherty wrote:
>> On 6/17/15 8:52 AM, Tom Benson wrote:
>>> Hi,
>>> Please review this change for JDK-8098815.  The CDS code which maps 
>>> the shared strings from an archive file must check for a zero length 
>>> before calling the G1 fill_archive_regions routine. It already 
>>> checks this before the earlier calls to check_archive_address and 
>>> alloc_archive_regions, for which fill_archive_regions is the final 
>>> step. The problem occurred only on Windows because the string table 
>>> is not included in the archive there.
>>>
>>> JBS:   https://bugs.openjdk.java.net/browse/JDK-8098815
>>> Webrev: http://cr.openjdk.java.net/~tbenson/8098815/webrev.00/
>>
>> src/share/vm/memory/filemap.cpp
>>     No comments.
>>
>>
>>> Tested: JPRT
>>
>> I think there needs to be at least one Windows test run with
>> at least one of the failing test suites named in the bug
>> report.
>>
>> Dan
>>
>>
>>>
>>> Thanks,
>>> Tom
>>>
>>>
>>>
>>
>