[RFR] (XS) 8087153: EXCEPTION_ACCESS_VIOLATION when CDS RO section vanished on win32
Coleen Phillimore
coleen.phillimore at oracle.com
Fri Jun 19 21:54:28 UTC 2015
Looks good!
Coleen
Sent from my iPhone
> On Jun 19, 2015, at 5:46 PM, Chris Plummer <chris.plummer at oracle.com> wrote:
>
>> On 6/19/15 2:43 PM, Daniel D. Daugherty wrote:
>>> On 6/19/15 3:35 PM, Chris Plummer wrote:
>>> Please review the following fix for 8087153:
>>>
>>> http://spiro.us.oracle.com/~cplummer/webrevs/8087153/webrev.00/webrev.hotspot/
>>> https://bugs.openjdk.java.net/browse/JDK-8087153
>>
>> Chris, the above webrev URL won't work for OpenJDK reviews. Please copy
>> your webrev to your space on cr.openjdk.java.net.
>>
>> src/share/vm/memory/filemap.cpp
>> No comments.
> This one should work. :)
>
> http://cr.openjdk.java.net/~cjplummer/8087153/webrev.00/
>
> Chris
>>
>> Thumbs up!
>>
>> Dan
>>
>>
>>
>>>
>>> This bug was introduced by the changes for 8054386, which mapped the archive RW even if RO was requested. The state of the space_info->read_only was not reflecting this, causing an unnecessary attempt to remap to RW later on when a method's bytecodes were rewritten. This remap exposed a race condition on win32.
>>>
>>> Since the changes are small, they will be committed once they are approved.
>>>
>>> thanks,
>>>
>>> Chris
>
More information about the hotspot-runtime-dev
mailing list