RFR (xs) 8129607: Incorrect GPL header

Coleen Phillimore coleen.phillimore at oracle.com
Wed Jun 24 11:26:28 UTC 2015


Hi Volker and Goetz,

I think all of the SAP copyrights are consistent in the sources without 
the (agree strange) second comma.  The bug description (confidential but 
you don't want to see it anyway) initially implied this was what was 
wrong, but Harold corrected me.  Phew.

Thanks,
Coleen

On 6/24/15 4:49 AM, David Holmes wrote:
> On 24/06/2015 6:21 PM, Lindenmaier, Goetz wrote:
>> Hi Coleen,
>>
>> this fix looks good!
>> How did you spot this, is there a check of the copyrights?
>>
>> When we did the port, we were told that the SAP copyright line
>> has no constraints, so we decided not to put in this strange comma
>> after the second year.
>
> As Colleen is sleeping ... :)
>
> There is nothing wrong with the SAP copyright and it is unchanged (see 
> the "second try" thread). We do have copyright checking periodically 
> and an error was flagged but the nature of the error was misunderstood 
> - initially it was thought the SAP copyright with no trailing comma 
> was to blame, but in fact the SAP copyright is ignored in the check - 
> as that is not what is being checked :) The actual error was a simple 
> typo in the GPL text: hat instead of that
>
> Cheers,
> David
>
>> Thanks for fixing this,
>>    Goetz.
>>
>> -----Original Message-----
>> From: hotspot-runtime-dev 
>> [mailto:hotspot-runtime-dev-bounces at openjdk.java.net] On Behalf Of 
>> Coleen Phillimore
>> Sent: Dienstag, 23. Juni 2015 23:03
>> To: hotspot-runtime-dev
>> Subject: RFR (xs) 8129607: Incorrect GPL header
>>
>> Please review small fix to GPL header.
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/8129607/
>>
>> Thanks,
>> Coleen
>>



More information about the hotspot-runtime-dev mailing list