RFR JDK-8071501 perfMemory_solaris.cpp failing to compile with "Error: dd_fd is not a member of DIR."

[Daniel D. Daugherty]

On 3/4/15 2:04 PM, Gerald Thornbrugh wrote:
> Hi,
>
> Please review my JDK8 and JDK9 fix for JDK-8071501 
> perfMemory_solaris.cpp failing to compile with
> "Error: dd_fd is not a member of DIR."
>
> This compiler error occurs when Solaris 11 include files are used to 
> build hotspot and the POSIX
> version of the DIR structure is used in the build process.  The fix 
> forces all Solaris builds to use
> the same version of the DIR structure.
>
> JDK8 Webrev: http://cr.openjdk.java.net/~gthornbr/fd/jdk8/webrev/ 
> <http://cr.openjdk.java.net/%7Egthornbr/fd/jdk8/webrev/>

src/os/solaris/vm/jvm_solaris.h
     No comments.

src/share/vm/utilities/globalDefinitions_sparcWorks.hpp
     No comments.

Thumbs up on the JDK8u version.

Jerry, your webrev is parented to:

     http://hg.openjdk.java.net/jdk8/jdk8/hotspot

which is not the right place. JDK8u/HSX-25.60 changes should
parent to:

     http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot


> JDK9 Webrev: http://cr.openjdk.java.net/~gthornbr/fd/jdk9/webrev/
> <http://cr.openjdk.java.net/%7Egthornbr/fd/jdk9/webrev/>

src/os/solaris/vm/jvm_solaris.h
     No comments.

src/share/vm/utilities/globalDefinitions_sparcWorks.hpp
     No comments.

Thumbs up on the JDK8u version.

Jerry, your webrev is parented to:

     http://hg.openjdk.java.net/jdk9/jdk9/hotspot

and it should be parented to:

     http://hg.openjdk.java.net/jdk9/hs-rt/hotspot

Sometimes we push emergency fixes to Main_Baseline:

     http://hg.openjdk.java.net/jdk9/hs/hotspot

or even to JDK9-dev:

     http://hg.openjdk.java.net/jdk9/dev/hotspot

but those are very rare occasions and require permission
from those GKs...

Dan


> I have completed JPRT bulds and tests on platforms without issues.
>
> Thanks,
>
> Gerald