RFR JDK-8071501 perfMemory_solaris.cpp failing to compile with "Error: dd_fd is not a member of DIR."
Dmitry Samersoff
dmitry.samersoff at oracle.com
Wed Mar 4 21:59:32 UTC 2015
Gerlad,
As the overall direction is be POSIX compatible,
it might be better to change the code to use POSIX declaration,
and define __XOPEN_OR_POSIX for Solaris 10 compatibility.
-Dmitry
On 2015-03-05 00:04, Gerald Thornbrugh wrote:
> Hi,
>
> Please review my JDK8 and JDK9 fix for JDK-8071501
> perfMemory_solaris.cpp failing to compile with
> "Error: dd_fd is not a member of DIR."
>
> This compiler error occurs when Solaris 11 include files are used to
> build hotspot and the POSIX
> version of the DIR structure is used in the build process. The fix
> forces all Solaris builds to use
> the same version of the DIR structure.
>
> JDK8 Webrev: http://cr.openjdk.java.net/~gthornbr/fd/jdk8/webrev/
> <http://cr.openjdk.java.net/%7Egthornbr/fd/jdk8/webrev/>
>
> JDK9 Webrev: http://cr.openjdk.java.net/~gthornbr/fd/jdk9/webrev/
> <http://cr.openjdk.java.net/%7Egthornbr/fd/jdk9/webrev/>
> I have completed JPRT bulds and tests on platforms without issues.
>
> Thanks,
>
> Gerald
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
More information about the hotspot-runtime-dev
mailing list