RFR(XS) 8073990: Deprecated "UseVectoredExceptions" VM options still defined in several globals files
Volker Simonis
volker.simonis at gmail.com
Wed Mar 11 17:04:08 UTC 2015
Hi Dmitry,
the change looks good but I think you should also remove the line:
{ "UseVectoredExceptions", JDK_Version::jdk(8), JDK_Version::jdk(9) },
from arguments.cpp with this change because in JDK9 you'd get an error
anyway if you'll try to use "UseVectoredExceptions".
Regards,
Volker
On Wed, Mar 11, 2015 at 5:38 PM, Dmitry Dmitriev
<dmitry.dmitriev at oracle.com> wrote:
> Hello,
>
> Please review this small fix for JDK-8073990. Also, I need a sponsor for
> this fix, who can push it, because I'm not have a OpenJDK name.
>
> This fix removes deprecated "UseVectoredExceptions" VM option from several
> header files related to aix_ppc and linux_ppc. Here a list of modified
> header files:
> src/os_cpu/aix_ppc/vm/globals_aix_ppc.hpp
> src/os_cpu/linux_ppc/vm/globals_linux_ppc.hpp
>
> The "UseVectoredExceptions" VM option was deprecated by JDK-7188234
> <https://bugs.openjdk.java.net/browse/JDK-7188234>, but was leaved in
> several header files. Thus, I remove it from remaining header files in
> hotspot repo.
>
> I am not build HotSpot with this fix.
>
> Also, one moment about what I am not 100% sure is are copyrights. I update
> copyright for Oracle and SAP AG to 2015, but I am not sure that I shall
> update SAP AG copyright. Correct me if I am wrong and SAP AG copyright shall
> leaved unchanged. Thanks!
>
> Open webrev: http://cr.openjdk.java.net/~coleenp/8073990/
> <http://cr.openjdk.java.net/%7Ecoleenp/8073990/>
>
> JBS bug: https://bugs.openjdk.java.net/browse/JDK-8073990
>
> Thanks,
> Dmitry
>
>
More information about the hotspot-runtime-dev
mailing list