RFR(XS) 8073990: Deprecated "UseVectoredExceptions" VM options still defined in several globals files

[David Holmes]

Hi Dmitry,

On 12/03/2015 5:40 AM, Dmitry Dmitriev wrote:
> Hi Volker,
>
> Thank you for review!
>
> This is a good point about arguments.cpp. I am not familiar with removing flags from obsolete_jvm_flags. But I think that this option should not removed by this fix. I think that we should up question about that situation and create a unified solution for such flags. I check, there about 50 flags with accept until equal or less than JDK 9. The unified solution can be develop, bug submitted and all these flags can be removed. What you think about that?

Volker is right. The deprecation entry has no meaning in JDK 9 as it 
simply reports:

Unrecognized VM option 'UseVectoredExceptions'

whereas in JDK8u it reports:

Java HotSpot(TM) Server VM warning: ignoring option 
UseVectoredExceptions; support was removed in 8.0

but there are many such cleanups needed so I agree about leaving this to 
a separate CR. When 9 ships the only deprecation options remaining 
should be those dropped in 9 and targeted for removal in 10.

I will push the current changes as-is.

Thanks,
David

> Regards,
> Dmitry
>
>
> ----- Original Message -----
> From: volker.simonis at gmail.com
> To: dmitry.dmitriev at oracle.com
> Cc: hotspot-runtime-dev at openjdk.java.net
> Sent: Wednesday, 11 March, 2015 8:04:11 PM GMT +03:00 Iraq
> Subject: Re: RFR(XS) 8073990: Deprecated "UseVectoredExceptions" VM options still defined in several globals files
>
> Hi Dmitry,
>
> the change looks good but I think you should also remove the line:
>
>    { "UseVectoredExceptions",         JDK_Version::jdk(8), JDK_Version::jdk(9) },
>
> from arguments.cpp with this change because in JDK9 you'd get an error
> anyway if you'll try to use "UseVectoredExceptions".
>
> Regards,
> Volker
>
>
> On Wed, Mar 11, 2015 at 5:38 PM, Dmitry Dmitriev
> <dmitry.dmitriev at oracle.com> wrote:
>> Hello,
>>
>> Please review this small fix for JDK-8073990. Also, I need a sponsor for
>> this fix, who can push it, because I'm not have a OpenJDK name.
>>
>> This fix removes deprecated "UseVectoredExceptions" VM option from several
>> header files related to aix_ppc and linux_ppc. Here a list of modified
>> header files:
>> src/os_cpu/aix_ppc/vm/globals_aix_ppc.hpp
>> src/os_cpu/linux_ppc/vm/globals_linux_ppc.hpp
>>
>> The "UseVectoredExceptions" VM option was deprecated by JDK-7188234
>> <https://bugs.openjdk.java.net/browse/JDK-7188234>, but was leaved in
>> several header files. Thus, I remove it from remaining header files in
>> hotspot repo.
>>
>> I am not build HotSpot with this fix.
>>
>> Also, one moment about what I am not 100% sure is are copyrights. I update
>> copyright for Oracle and SAP AG to 2015, but I am not sure that I shall
>> update SAP AG copyright. Correct me if I am wrong and SAP AG copyright shall
>> leaved unchanged. Thanks!
>>
>> Open webrev: http://cr.openjdk.java.net/~coleenp/8073990/
>> <http://cr.openjdk.java.net/%7Ecoleenp/8073990/>
>>
>> JBS bug: https://bugs.openjdk.java.net/browse/JDK-8073990
>>
>> Thanks,
>> Dmitry
>>
>>