RFR(S) 8075216: Remove old flags, regarding to JDK9, from obsolete_jvm_flags

Volker Simonis volker.simonis at gmail.com
Wed Mar 18 16:04:32 UTC 2015


Hi Dmitry,

sorry, you're right. I looked in the wrong repository.

I'm fine with your change now.

Regards,
Volker


On Wed, Mar 18, 2015 at 4:27 PM, Dmitry Dmitriev
<dmitry.dmitriev at oracle.com> wrote:
> Hi Volker,
>
> Recently I perform analysis of these flags and results are below:
> UseVectoredExceptions option was removed from specified files by
> https://bugs.openjdk.java.net/browse/JDK-8073990 but fix is not propagated
> to the jdk9/dev.
>
> All other options are not exists in the sources except for
> DesiredMethodLimit. DesiredMethodLimit option exist and used in source code,
> but it defined as "develop" option. This option was added to the
> obsolete_jvm_flags to eliminate difference between options  in oracle and
> openjdk builds(https://bugs.openjdk.java.net/browse/JDK-7061192). There are
> no reasons to keep it in obsolete_jvm_flags because accept_until for this
> option is JDK8 and for JDK9 this option will be skipped in
> obsolete_jvm_flags.
>
> Regards,
> Dmitry
>
>
> On 18.03.2015 18:01, Volker Simonis wrote:
>>
>> Hi Dmitry,
>>
>> can you please make sure that none of these options which you will
>> remove is still used anywhere else in the sources. I've just
>> cherry-picked some of the options and saw that for example
>> UseVectoredExceptions is still present in
>> ../hotspot/src/os_cpu/aix_ppc/vm/globals_aix_ppc.hpp and
>> ../hotspot/src/os_cpu/linux_ppc/vm/globals_linux_ppc.hpp for example.
>>
>>
>> Thanks,
>> Volker
>>
>>
>> On Wed, Mar 18, 2015 at 2:47 PM, Dmitry Dmitriev
>> <dmitry.dmitriev at oracle.com> wrote:
>>>
>>> Hello David,
>>>
>>> Thank you for review and sponsorship!
>>>
>>> I add suggested comment:
>>> http://cr.openjdk.java.net/~ctornqvi/webrev/8075216/webrev.01/
>>> <http://cr.openjdk.java.net/%7Ectornqvi/webrev/8075216/webrev.01/>
>>>
>>> Regards,
>>> Dmitry
>>>
>>>
>>> On 18.03.2015 3:50, David Holmes wrote:
>>>>
>>>> Hi Dmitry,
>>>>
>>>> On 18/03/2015 2:03 AM, Dmitry Dmitriev wrote:
>>>>>
>>>>> Hello,
>>>>>
>>>>> Please review this small fix which remove old deprecated
>>>>> options(regarding to JDK 9) from obsolete_jvm_flags table.
>>>>
>>>>
>>>> We could completely re-do the obsolete option mechanism now that hsx is
>>>> not an issue, but simply deleting all the already invalid options is
>>>> fine.
>>>> Though some additional commentary we be useful:
>>>>
>>>> 241  * limit, we flatly refuse to admit the existence of the flag.  This
>>>> allows
>>>> 242  * a flag to die correctly over JDK releases using HSX.
>>>> +    * But now that HSX is no longer supported only options
>>>> +    * with a future accept_until value need to be listed, and
>>>> +    * the list can be pruned on each major release.
>>>>
>>>>> Also, I need a sponsor for this fix, who can push it, because I'm not
>>>>> have a OpenJDK name.
>>>>
>>>>
>>>> I can sponsor this.
>>>>
>>>> Thanks,
>>>> David
>>>>
>>>>> Webrev: http://cr.openjdk.java.net/~ctornqvi/webrev/8075216/webrev.00/
>>>>> <http://cr.openjdk.java.net/%7Ectornqvi/webrev/8075216/webrev.00/>
>>>>>
>>>>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8075216
>>>>>
>>>>> Thank you,
>>>>> Dmitry
>>>
>>>
>


More information about the hotspot-runtime-dev mailing list