RFR(s): 8076181: bytecodeInterpreter.cpp refers to unknown labels.
Coleen Phillimore
coleen.phillimore at oracle.com
Fri Mar 27 15:58:23 UTC 2015
Yes, this is good. Sorry, I reviewed this and didn't think it would
break anything (obviously wrong). I think this can be checked in
directly by a committer.
Thanks!
Coleen
On 3/27/15, 11:49 AM, Severin Gehwolf wrote:
> Hi,
>
> Could somebody please review and sponsor this change?
>
> JDK-8074345 introduced new jumps to labels which were undefined in
> bytecodeInterpreter.cpp. This makes release builds of Zero fail[1],
> since it uses the computed goto approach rather than a switch statement
> which debug builds use. AFAIK, Zero is the only remaining user of the C
> ++ interpreter.
>
> The fix is to not introduce those unknown labels since they aren't
> implemented anyway. Note: CDS is not implemented in Zero. I'm not
> entirely sure why 8076181 touched bytecodeInterpreter.cpp in the first
> place.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8076181
> webrev:
> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8076181/webrev.01/
>
> Thanks,
> Severin
>
> [1]
> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2015-March/014315.html
>
More information about the hotspot-runtime-dev
mailing list