RFR(S) 8076318: split verifier needs to add TraceClassResolution

harold seigel harold.seigel at oracle.com
Mon May 4 17:45:10 UTC 2015


Hi Karen,

Thanks for the review.  The names you suggest are much better.  I'll 
change them.

Harold

On 5/4/2015 1:23 PM, Karen Kinnear wrote:
> Harold,
>
> Thank you so much for doing this. Looks good.
>
> A request - in trace_class_resolution, could you possibly rename the arguments. The first one is perhaps resolve_class and the second
> perhaps verify_class?
>
> The to and from are confusing - e.g. verificationType.cpp you set arg "to_class" to from_class.
>
> thanks,
> Karen
>
> On May 1, 2015, at 8:49 AM, harold seigel wrote:
>
>> Hi,
>>
>> Please review this small change to the split verifier to generate output for the classes it loads when -XX:+TraceClassResolution is specified.  The verifier output for this flag will look like this:
>>
>>    RESOLVE java.lang.ClassLoader java.util.Set ClassLoader.java
>>    (verification)
>>    RESOLVE java.lang.ClassLoader java.lang.Throwable ClassLoader.java
>>    (verification)
>>
>> The first class is the class being resolved.  The second class is the one being loaded.
>>
>> Open webrev: http://cr.openjdk.java.net/~hseigel/bug_8076318/
>>
>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8076318
>>
>> The change was tested with JCK lang, vm, and api tests, hotspot jtreg tests, testbase quick tests, and the new test included in the webrev.
>>
>> Thanks, Harold



More information about the hotspot-runtime-dev mailing list