RFR(S) 8076318: split verifier needs to add TraceClassResolution

[Coleen Phillimore]

On 5/4/15, 9:38 AM, harold seigel wrote:
> Hi Coleen,
>
> Thanks for review.  I tried to match the new verifier 
> TraceClassResolution output with existing output for that qualifier.  
> That output varies slightly but here's some examples of the existing 
> output:
>
>    RESOLVE java.lang.Throwable java.io.Serializable (interface)
>    RESOLVE java.lang.Error java.lang.Throwable (super)
>    RESOLVE java.util.Hashtable java.util.Map$Entry Hashtable.java:530
>    RESOLVE java.util.Hashtable java.util.Hashtable$Entry 
> Hashtable.java:441
>
> Adding additional text to the verifier output for TraceClassResolution 
> would be useful but not consistent unless added for all output.
>
> In the new verifier output, the first class is the one being verified, 
> the second class is getting loaded as part of the verification of the 
> first class.

Okay, if this output is useful for you, consider it reviewed.
Coleen

>
> Thanks, Harold
>
> On 5/4/2015 9:24 AM, Coleen Phillimore wrote:
>>
>> The code looks okay but you could add more information.   Is the 
>> first class getting resolved as a result of the second class getting 
>> loaded?
>>
>> In TraceClassLoading, the source file has the full path iirc. But it 
>> looks like you don't have that information.  I still think english 
>> words in between the message would be more helpful.
>>
>> Coleen
>>
>> On 5/1/15, 8:49 AM, harold seigel wrote:
>>> Hi,
>>>
>>> Please review this small change to the split verifier to generate 
>>> output for the classes it loads when -XX:+TraceClassResolution is 
>>> specified.  The verifier output for this flag will look like this:
>>>
>>>    RESOLVE java.lang.ClassLoader java.util.Set ClassLoader.java
>>>    (verification)
>>>    RESOLVE java.lang.ClassLoader java.lang.Throwable ClassLoader.java
>>>    (verification)
>>>
>>> The first class is the class being resolved.  The second class is 
>>> the one being loaded.
>>>
>>> Open webrev: http://cr.openjdk.java.net/~hseigel/bug_8076318/
>>>
>>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8076318
>>>
>>> The change was tested with JCK lang, vm, and api tests, hotspot 
>>> jtreg tests, testbase quick tests, and the new test included in the 
>>> webrev.
>>>
>>> Thanks, Harold
>>
>