RFR: 8079301: Some command line options not settable via JAVA_TOOL_OPTIONS

[David Holmes]

Hi Jeremy,

On 5/05/2015 6:51 AM, Jeremy Manson wrote:
> Not sure who might be willing to sponsor this.  David?  You did the last
> one.  :)

Might be a while before I can get to it. I did have a quick look (and 
will need a longer one).

> Context: A number of command line options are not settable via
> JAVA_TOOL_OPTIONS and _JAVA_OPTIONS:
>
>    - PrintVMOptions

So you have changed the semantics of this to print out the options from 
the command-line and each of the two env vars. Seems reasonable but may 
be better to know which option came from where as we can now see the 
same option (or conflicting variants thereof) multiple times.

I'm unclear what the current processing order is for the different 
sources of options, and whether the changes affect that order?

>    - IgnoreUnrecognizedVMOptions
>    - PrintFlagsInitial

Unclear what "initial" actually means - is it the default?

>    - NativeMemoryTracking
>    - PrintFlagsWithComments
>
> This is because these flags have to be processed before processing other
> flags, and no one ever bothered to do that for the flags coming from
> environment variables.  This patch fixes that problem.
>
> I have a test, but it is a modification to a JDK test instead of a HS test,
> so it can go in separately (I guess).

They can be pushed together to different repos in the same forest.

As I said I'll have to get back to this. And hopefully someone else in 
runtime will take a good look as well ;-)

Cheers,
David


> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8079301
>
> Webrev:
> http://cr.openjdk.java.net/~jmanson/8079301/webrev.00/
>
> Jeremy
>