RFR (S): 8072588 - JVM crashes in JNI if toString is declared as an interface method

[Andreas Eriksson]

Hi,

David, I've added the native test to the test suite, could you take a 
look please?

I still need a Reviewer to take a look at this as well.

New webrev: http://cr.openjdk.java.net/~aeriksso/8072588/webrev.01/
Bug: https://bugs.openjdk.java.net/browse/JDK-8072588

Thanks,
Andreas

On 2015-03-20 10:14, David Simms wrote:
>
> Looks good to me (not a 'R'-eviewer)
>
> I'd like to have your test checked in if possible. Native JNI testing 
> has just recently been added, we can talk about the details off-list.
>
> /David Simms
>
> On 19/03/15 17:45, Andreas Eriksson wrote:
>> Hi,
>>
>> Could someone please take a look at this?
>>
>> Regards,
>> Andreas
>>
>> On 2015-03-10 17:10, Andreas Eriksson wrote:
>>> Hi,
>>>
>>> Please review this fix for a JNI issue in jni_invoke_nonstatic.
>>>
>>> The problem is that when toString is declared as an interface method 
>>> it still has a vtable index, not an itable index as 
>>> jni_invoke_nonstatic expects.
>>>
>>> This fix checks for a valid itable index instead of checking if the 
>>> holder is an interface.
>>> I also moved a duplicated check for JNI_VIRTUAL to be done in one 
>>> check instead.
>>> The change has been verified to fix the problem with a small JNI 
>>> test, and has passed a jprt run with the hotspot testset.
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~aeriksso/8072588/webrev.00/
>>>
>>> Regards,
>>> Andreas
>>
>