RFR(XS) 8033445: Add test case for calling default methods from JNI

David Simms david.simms at oracle.com
Fri May 8 07:56:11 UTC 2015


Looks good

On 07/05/15 18:32, Stas Smirnov wrote:
> Hi,
>
> I have modified the "java" test code to support jtreg agentvm run 
> mode, please take a look.
> webrev: http://cr.openjdk.java.net/~stsmirno/8033445/webrev.04/
> <http://cr.openjdk.java.net/%7Estsmirno/8033445/webrev.04/>Christian, 
> please sponsor the change if you are ok with it.
>
> 28.04.2015 18:26, Christian Tornqvist пишет:
>> Hi Stas,
>>
>> This looks good, I can sponsor the change for you.
>>
>> Thanks,
>> Christian
>>
>> -----Original Message-----
>> From: hotspot-runtime-dev 
>> [mailto:hotspot-runtime-dev-bounces at openjdk.java.net] On Behalf Of 
>> Stas Smirnov
>> Sent: Tuesday, April 28, 2015 10:12 AM
>> To: hotspot-runtime-dev at openjdk.java.net
>> Subject: Re: RFR(XS) 8033445: Add test case for calling default 
>> methods from JNI
>>
>> Hi,
>>
>> one more update, start using FatalError to avoid extra checks and 
>> return statements, please take a look.
>> webrev: http://cr.openjdk.java.net/~stsmirno/8033445/webrev.03/
>> <http://cr.openjdk.java.net/%7Estsmirno/8033445/webrev.03>
>>
>> I still need a sponsor for this fix, who can push it.
>>
>> On 23.04.2015 17:01, Stas Smirnov wrote:
>>> Hello,
>>>
>>> forgot to move tests to a specific "jni" folder, please take a look
>>> Open webrev: http://cr.openjdk.java.net/~stsmirno/8033445/webrev.02/
>>>
>>> 23.04.2015 15:58, Stas Smirnov пишет:
>>>> Hello,
>>>>
>>>> here is an updated fix for JDK-8033445 that includes copyrights.
>>>> I still need a sponsor for this fix, who can push it.
>>>>
>>>> Open webrev: http://cr.openjdk.java.net/~stsmirno/8033445/webrev.01/
>>>>
>>>> JBS bug: https://bugs.openjdk.java.net/browse/JDK-8033445
>>>>
>>>> 20.04.2015 15:22, Stas Smirnov пишет:
>>>>> Hello,
>>>>>
>>>>> Please review this fix for JDK-8033445. Also, I need a sponsor for
>>>>> this fix, who can push it.
>>>>>
>>>>> As a fix for JDK-8033445 a new set of tests has been developed to
>>>>> call default methods from JNI and verify the result.
>>>>>
>>>>> Open webrev: http://cr.openjdk.java.net/~stsmirno/8033445/webrev.00/
>>>>> <http://cr.openjdk.java.net/%7Estsmirno/8033445/webrev.00/>
>>>>>
>>>>> JBS bug: https://bugs.openjdk.java.net/browse/JDK-8033445
>>>>>
>>>>> Tested: JPRT
>>>>
>>>
>>> -- 
>>>
>>> Best regards,
>>> Stas Smirnov
>>>
>>> Stas Smirnov | Java VM Runtime SQE
>>> Phone: +7 812 3346130 | Mobile: +7 921 9262241 Oracle Development SPB,
>>> LLC 10th Krasnoarmeyskaya 22A, St. Petersburg, 190103, Russia
>>>
>>
>
>



More information about the hotspot-runtime-dev mailing list