RFR(S): 8080718 - -XX:CreateCoredumpOnCrash doesn't work for jni_FatalError

[David Holmes]

Hi Christian,

On 30/05/2015 6:11 AM, Christian Tornqvist wrote:
> Hi everyone,
>
> Please review this small change that enables the CreateCoredumpOnCrash flag
> to control core dumping when os::abort() is being called from JNI Fatal
> Errors (when running with -Xcheck:jni).

But it does more than that, it enables CreateCoredumpOnCrash to control 
coredumps in all cases that os::abort() or os::abort(true) is called. In 
particular it now also controls vm_abort(). I actually think that is a 
good thing given the description of the flag:

"Create core/mini dump on VM fatal error"

But I think this needs to be reflected in the CR as well.

Good to see the duplicated os::abort definitions disappear too.

Cheers,
David

>
>
> Webrev:
>
> http://cr.openjdk.java.net/~ctornqvi/webrev/8080718/webrev.00/
>
>
>
> Bug:
>
> https://bugs.openjdk.java.net/browse/JDK-8080718
>
>
>
> Thanks,
>
> Christian
>