RFR: 8140348: Convert TraceSafepoint to Unified Logging

Coleen Phillimore coleen.phillimore at oracle.com
Tue Nov 3 23:44:36 UTC 2015


Hi Rachel,

I think these code changes look really good!  A couple of comments:

http://cr.openjdk.java.net/~rprotacio/8140348/test/runtime/logging/SafepointTestMain.java.html

Around line 51 could you add a comment that the purpose of running 
B.infinite() in a thread is to get it to compile so that a safepoint 
message is printed for the compiled method.

And add a comment around 57 that says something like cause several 
safepoints to run GC while the compiled method is running, to see 
safepoint messages.  Or something like that.

I'll sponsor your change.  The hotspot changes look good.  Actually 
logging looks a lot cleaner in the code for this one than checking the 
flag and printing to tty.

Thanks!
Coleen

On 10/22/15 1:33 PM, Rachel Protacio wrote:
> Hello,
>
> Please review my next logging enhancement.
>
> Summary: The former -XX:+TraceSafepoint flag is updated to the unified 
> logging framework and is now replaced with -Xlog:safepoint in product 
> mode.
>
> open webrev: http://cr.openjdk.java.net/~rprotacio/8140348/
> bug link: https://bugs.openjdk.java.net/browse/JDK-8140348
> testing: Passes JPRT, RBT, and RefWorkload performance testing.
>
> A compatibility request has been accepted with regard to this change.
>
> Thank you,
> Rachel



More information about the hotspot-runtime-dev mailing list