RFR (S) round 0 for 8141068 Refactor -XXFlags= code in preparation for removal

Ron Durbin ron.durbin at oracle.com
Tue Nov 10 21:02:08 UTC 2015


Coleen

This is to formally respond to your email.  Dan and I agreed the change you are requesting should be done, but not
in this change set.  Keeping this change set to only XX:Flags changes. A future change set that could clean up
the options file processing should address your issue.

Ron


>-----Original Message-----
>From: Coleen Phillimore
>Sent: Monday, November 09, 2015 2:03 PM
>To: hotspot-runtime-dev at openjdk.java.net
>Subject: Re: RFR (S) round 0 for 8141068 Refactor -XXFlags= code in preparation for removal
>
>
>Ron,
>
>This looks really good!  Although I don't see why you need to pass
>vm_options_file argument into match_special_options_and_act now since
>it's not used afterward, so you only have to pass one NULL in the cases
>where vm_options_file is not allowed.
>
>thanks,
>Coleen
>
>On 11/6/15 2:05 PM, Ron Durbin wrote:
>> This bug fix consists of a refactoring/cleanup of the -XX:Flags code.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~rdurbin/8141068_OCR0_JDK9_webrev
>>
>>
>> Bug report:
>> https://bugs.openjdk.java.net/browse/JDK-8141068
>>
>> This bug fix has been tested on:
>>     OS:
>>       Solaris, MAC, Windows, Linux
>>     Tests:
>>       Manual unit tests
>>       JPRT with -testset hotspot(including the SQE current test coverage for this feature.)
>


More information about the hotspot-runtime-dev mailing list