RFR: 8141445: Use of Solaris/SPARC M7 libadimalloc.so can generate unknown signal in hs_err file

[Daniel D. Daugherty]

On 11/12/15 7:44 AM, Gerald Thornbrugh wrote:
> Hi David,
>
> I will remove the "#ifdef SOLARIS" and retest.

Don't forget this part of David's comment:

 > the test should only be built on solaris/sparc - via conditional
 > inclusion in the sources listed in the JtregNative.gmk file.

Dan


>
> Thanks!
>
> Jerry
>> Hi Jerry,
>>
>> On 11/11/2015 12:47 AM, Gerald Thornbrugh wrote:
>>> Hi Everyone,
>>>
>>> I have made the changes that David Holmes and Dan Daugherty 
>>> suggested, below is the webrev:
>>>
>>> http://cr.openjdk.java.net/~gthornbr/8141445/webrev.01/ 
>>> <http://cr.openjdk.java.net/~gthornbr/8141445/webrev.01/>
>>>
>>> Please let me know if you have any questions or concerns.
>>
>> If this is only for solaris/sparc then the test should only be built 
>> on solaris/sparc - via conditional inclusion in the sources listed in 
>> the JtregNative.gmk file. That way you don't need any #ifdef SOLARIS 
>> in the code (not that I'm clear why they are needed anyway ??).
>>
>> Otherwise changes look good.
>>
>> Thanks,
>> David
>>
>>
>>> Thanks,
>>>
>>> Jerry
>>>> On Nov 4, 2015, at 2:15 PM, Gerald Thornbrugh 
>>>> <gerald.thornbrugh at oracle.com> wrote:
>>>>
>>>> Hi Everyone,
>>>>
>>>> Please review my fix for JDK-8141445.
>>>>
>>>> JDK-8141445 describes an issue seen only on Solaris/SPARC M7 
>>>> hardware running Solaris 11.3 or later when the libadimalloc.so 
>>>> library is
>>>> preloaded before running the JVM and the JVM crashes due to a 
>>>> memory allocation fault triggered by libadimalloc.so. Currently when
>>>> libadimalloc.so triggers a memory allocation fault the SIGSEGV 
>>>> si_code is displayed as “unknown" in the hs_err file.  This change 
>>>> adds
>>>> additional si_code defines so the memory allocation faults that 
>>>> trigger the JVM to core are displayed correctly in the hs_err file.
>>>> The changes also include a test that preloads the libadimalloc.so 
>>>> library, generates a libadimalloc.so memory allocation fault that 
>>>> crashes
>>>> the JVM and then verifies that the correct si_code information is 
>>>> displayed in the hs_err file.
>>>>
>>>> Webrev: http://cr.openjdk.java.net/~gthornbr/8141445/webrev.00/ 
>>>> <http://cr.openjdk.java.net/~gthornbr/8141445/webrev.00/>
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8141445 
>>>> <https://bugs.openjdk.java.net/browse/JDK-8141445>
>>>>
>>>> Please let me know if you have any questions or concerns.
>>>>
>>>> Thanks,
>>>>
>>>> Jerry
>>>
>