(S) RFR: 8141024: [Solaris] Obsolete UseAltSigs

[Dmitry Dmitriev]

David,

Looks good to me!

Thanks,
Dmitry

On 16.11.2015 2:57, David Holmes wrote:
> Hi Dmitry,
>
> On 16/11/2015 6:06 AM, Dmitry Dmitriev wrote:
>> Hello David,
>>
>> As Sergei wrote, the link to the webrev is missed, but I think here is
>> the right one: http://cr.openjdk.java.net/~dholmes/8141024/webrev/
>> <http://cr.openjdk.java.net/%7Edholmes/8141024/webrev/>
>
> Yes that is the one - sorry about the missing link.
>
>> Look good to me, just one comment:
>> 1) src/share/vm/runtime/arguments.cpp
>>
>> Lines 3040-3042: Some time ago when I deprecate other -X flags you
>> recommend to use JDK_Version::jdk(9) instead of hardcoded string,
>> because it won't need to be updated when the new version string comes
>> in. Probably, you can do the same? :)
>> Also, I think that you can just add "-Xusealtsigs" to the "if" at lines
>> 2954-2957 to the other deprecated -X options, i.e. something like that:
>>       } else if (match_option(option, "-Xoss", &tail) ||
>>                  match_option(option, "-Xsqnopause") ||
>>                  match_option(option, "-Xoptimize") ||
>>                  match_option(option, "-Xboundthreads") ||
>>                  match_option(option, "-Xusealtsigs")) {
>>         // All these options are deprecated in JDK 9 and will be removed
>> in a future release
>>         char version[256];
>>         JDK_Version::jdk(9).to_string(version, sizeof(version));
>>         warning("Ignoring option %s; support was removed in %s",
>> option->optionString, version);
>
> Good suggestion - updated webrev:
>
> http://cr.openjdk.java.net/~dholmes/8141024/webrev.v2
>
> Thanks,
> David
>
>
>> Thanks,
>> Dmitry
>>
>> On 14.11.2015 10:45, David Holmes wrote:
>>> Ping!
>>>
>>> Thanks,
>>> David
>>>
>>> On 13/11/2015 11:31 AM, David Holmes wrote:
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8141024
>>>>
>>>> webrev:
>>>>
>>>>
>>>> History:
>>>>
>>>> The JVM claimed SIGUSR1 and SIGUSR2 for the INTERRUPT and ASYNC 
>>>> signals,
>>>> respectively.
>>>>
>>>> -Xusealtsigs, mapping to -XX:+UseAltSigs, was provided to allow 
>>>> users to
>>>> reclaim those signals and instead use two of the real-time signals
>>>> (between SIGRTMIN and SIGRTMAX)
>>>>
>>>> As of Solaris 10, Solaris provides SIGJVM1 and SIGJVM2 exclusively for
>>>> the JVMs use. This avoids any conflict with user-defined signal usage.
>>>>
>>>> As of Java 6 we documented that on Solaris 10
>>>> -Xusealtsigs/-XX:+UseAltSigs had no affect:
>>>>
>>>> http://www.oracle.com/technetwork/java/javase/signals-139944.html#gbzbh 
>>>>
>>>>
>>>> As we no longer support Solaris versions older than 10, we do not need
>>>> the UseAltSigs functionality and the flags can be made Obsolete.
>>>>
>>>> Thanks,
>>>> David
>>