RFR: Round 2 for 8141445: Use of Solaris/SPARC M7 libadimalloc.so can generate unknown signal in hs_err file

[Daniel D. Daugherty]

On 11/17/15 7:49 AM, Gerald Thornbrugh wrote:
> Hi Everyone,
>
> Please review my fix for JDK-8141445.
>
> JDK-8141445 describes an issue seen only on Solaris/SPARC M7 hardware running Solaris 11.3 or later when the libadimalloc.so library is
> preloaded before running the JVM and the JVM crashes due to a memory allocation fault triggered by libadimalloc.so.  Currently when
> libadimalloc.so triggers a memory allocation fault the SIGSEGV si_code is displayed as “unknown" in the hs_err file.  This change adds
> additional si_code defines so the memory allocation faults that trigger the JVM to core are displayed correctly in the hs_err file.
> The changes also include a test that preloads the libadimalloc.so library, generates a libadimalloc.so memory allocation fault that crashes
> the JVM and then verifies that the correct si_code information is displayed in the hs_err file.
>
> I have implemented the changes requested by Dan Daugherty and David Holmes.
>
> Webrev: http://cr.openjdk.java.net/~gthornbr/8141445/webrev.02/

make/test/JtregNative.gmk
     No comments.

src/os/posix/vm/os_posix.cpp
     No comments.

test/runtime/libadimalloc.solaris.sparc/SEGVOverflow.java
     L38:         return;
         This 'return' is not needed since you're about to return
         from the main() function.

test/runtime/libadimalloc.solaris.sparc/Testlibadimalloc.java
     No comments.

test/runtime/libadimalloc.solaris.sparc/liboverflow.c
     No comments.

Thumbs up.

I don't need to see another webrev if you remove the 'return' above.

Dan


>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8141445 <https://bugs.openjdk.java.net/browse/JDK-8141445>
>
> Please let me know if you have any questions or concerns.
>
> Thanks,
>
> Jerry