RFR(XS): 8066814: Reduce accessibility in TraceEvent

Jaroslav Bachorik jaroslav.bachorik at oracle.com
Fri Nov 20 10:02:11 UTC 2015


Thumbs up!

-JB-

On 19.11.2015 16:21, Erik Gahlin wrote:
> Looks good, not a reviewer.
>
> Erik
>
> On 2014-12-17 15:45, Markus Grönlund wrote:
>>
>> Greetings,
>>
>> Kindly asking for reviews for the following changeset:
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8066814
>>
>> Webrev: http://cr.openjdk.java.net/~mgronlun/8066814/webrev01/
>> <http://cr.openjdk.java.net/%7Emgronlun/8066814/webrev01/>
>>
>> Description:
>>
>> TraceEvent currently exposes internals unnecessarily.
>>
>> Therefore:
>>
>> Remove unnecessarily exposed methods.
>> Add assert for not committing a cancelled event.
>> Add method stubs for !INCLUDE_TRACE
>>
>> Thanks in advance
>>
>> Markus
>>
>



More information about the hotspot-runtime-dev mailing list