RFR(S): aarch64 Fix loading ConstantPoolCacheEntry._indices with load acquire

Andrew Haley aph at redhat.com
Sat Nov 21 10:42:02 UTC 2015


The patch looks good.

I suggest some minor changes.

   // n.b. unlike x86 cache alreeady includes the index offset

Please correct to "already"


This

   ldrw(bytecode, Address(cache,
                          ConstantPoolCache::base_offset()
                          + ConstantPoolCacheEntry::indices_offset()));

could simply be changed to

   lea(bytecode, Address(cache,
                         ConstantPoolCache::base_offset()
                         + ConstantPoolCacheEntry::indices_offset()));
   ldarw(bytecode, bytecode);

which would be more idiomatic for this port.  It generates the same
code.

Andrew.


More information about the hotspot-runtime-dev mailing list