RFR: JDK-8138574: [TESTBUG] TestBasicLogOutput.java doesn't account for padding

Dmitry Dmitriev dmitry.dmitriev at oracle.com
Thu Oct 1 10:51:47 UTC 2015


Hello Rachel,

Looks good to me!

Thanks,
Dmitry

On 30.09.2015 23:40, Rachel Protacio wrote:
> Hi again,
>
> Please see my updated webrev which incorporates Dmitry's suggestion to 
> use a regex to ensure a full and proper match.
>
> Webrev: http://cr.openjdk.java.net/~coleenp/8138574.01/
>
> Update passes jtreg.
>
> Thanks,
> Rachel
>
> On 9/29/2015 1:34 PM, Rachel Protacio wrote:
>> Hello! Please review this one-character change to fix bug 8138574, 
>> where the existing test was not general enough to pass as new logging 
>> tags are added.
>>
>> Summary: TestBasicLogOutput.java edited to account for padding in tag 
>> descriptors
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8138574
>> Webrev: http://cr.openjdk.java.net/~coleenp/8138574
>>
>> Testing: passes jtreg on own and when tested with added tags
>>
>> Thank you,
>> Rachel
>



More information about the hotspot-runtime-dev mailing list