RFR (S): 8137105: [TESTBUG] Add test cases for VM Options file feature with removed file size limit

[Dmitry Dmitriev]

Hello Dan,

Thank you for review and comments! Here are corrected version:
webrev.01: http://cr.openjdk.java.net/~ddmitriev/8137105/webrev.01/ 
<http://cr.openjdk.java.net/%7Eddmitriev/8137105/webrev.01/>
webrev.01.vs.00: 
http://cr.openjdk.java.net/~ddmitriev/8137105/webrev.01.vs.00/ 
<http://cr.openjdk.java.net/%7Eddmitriev/8137105/webrev.01.vs.00/>

Dmitry

On 01.10.2015 0:41, Daniel D. Daugherty wrote:
> On 9/25/15 6:19 AM, Dmitry Dmitriev wrote:
>> Hello,
>>
>> Please review modifications to the tests for recently added feature: 
>> JDK-8061999 "Enhance VM option parsing to allow options to be 
>> specified in a file". These modifications reflect changes in the 
>> feature, which remove file size limit(currently also on review): 
>> JDK-8135195 "VM Options file should not be limited to 1024 bytes"
>>
>> Here are difference with previous version:
>> 1) Removed test cases which verifies that JVM reject VM Options file 
>> with size greater than 1024 bytes.
>> 2) Added test cases for VM Options size with size greater than 1024 
>> bytes(one with property with very long name and very long value, 
>> other with a lot of repeated properties in the VM Options file).
>> 3) Various small enchantments: added check for special options to the 
>> "last argument wins" test cases and others.
>>
>> Webrev: http://cr.openjdk.java.net/~ddmitriev/8137105/webrev.00/ 
>> <http://cr.openjdk.java.net/%7Eddmitriev/8137105/webrev.00/>
>
> test/runtime/CommandLine/VMOptionsFile/TestVMOptionsFile.java
>     L67:     private static final int REPEATE_COUNT = 512;
>         Typo: 'REPEATE_COUNT' -> 'REPEAT_COUNT'
>         Of course, don't forget to update the places that use the 
> variable. :-)
>
>     L74:     /* VM Option file with long property(file size is 1024 
> bytes) */
>         Seems like LONG_PROPERTY_VALUE will be longer than 1024...
>
> test/runtime/CommandLine/VMOptionsFile/optionfile_1
>     No comments.
>
> test/runtime/CommandLine/VMOptionsFile/optionfile_lot_of_options_quote
>     No comments.
>
> test/runtime/CommandLine/VMOptionsFile/optionfile_quote
>     No comments.
>
> test/runtime/CommandLine/VMOptionsFile/optionfile_long_property
> test/runtime/CommandLine/VMOptionsFile/optionfile_quote_max_size
> test/runtime/CommandLine/VMOptionsFile/optionfile_very_long_property
>     No comments on the deleted files.
>
> Thumbs up. I don't need to see a new webrev for the minor
> things that I noted above.
>
> Dan
>
>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8137105
>> Tested: JPRT with new test and with removed file size limit
>>
>> Thank you,
>> Dmitry
>