RFR(xxs): [windows] Build broken on VS2010 after "8046148: JEP 158: Unified JVM Logging"

[Thomas Stüfe]

Hi all,

may I have a sponsor please?

Or have we decided not to fix this ?

Regards, Thomas

On Thu, Oct 1, 2015 at 9:41 AM, Thomas Stüfe <thomas.stuefe at gmail.com>
wrote:

> Hi all,
>
> New version of this patch:
>
> http://cr.openjdk.java.net/~stuefe/webrevs/8137329/webrev.01/webrev/
>
> As Volker suggests, makes the workaround depend on _MSC_VER and also moves
> the patch to globalDefinitions_visCPP.hpp where it fits better and works
> for the whole hotspot.
>
> Kind regards, Thomas
>
>
> On Wed, Sep 30, 2015 at 3:51 PM, Volker Simonis <volker.simonis at gmail.com>
> wrote:
>
>> Hi,
>>
>> I second Phil,Goetz and Magnus and think this is a good change.
>>
>> But I suggest we should use "#if _MSC_VER < 1800" together with a
>> small comment instead of "#ifdef _WIN32" to make it more clear why we
>> have to redefine strtoull.
>>
>> Regards,
>> Volker
>>
>>
>> On Wed, Sep 30, 2015 at 3:37 PM, Magnus Ihse Bursie
>> <magnus.ihse.bursie at oracle.com> wrote:
>> > On 2015-09-30 14:40, Thomas Stüfe wrote:
>> >>
>> >> I would like to hear more opinions, and possibly a sponsor and a
>> reviewer.
>> >>
>> >> In my opinion it makes sense to fix this. The fix is small and cheap
>> and
>> >> makes people happy who still work with older versions of VS2010.
>> >
>> > I agree. It makes sense for trivial fixes to extend the range of
>> compiler
>> > versions that are possible to use. Major changes to support older
>> compilers
>> > is another thing, but simple stuff like this should be a no-brainer.
>> This is
>> > not really related to the fact that Oracle internally uses a specific
>> > version for daily quality control.
>> >
>> > /Magnus
>> >
>> >>
>> >> Kind Regards, Thomas
>> >>
>> >> On Tue, Sep 29, 2015 at 5:12 PM, Thomas Stüfe <thomas.stuefe at gmail.com
>> >
>> >> wrote:
>> >>
>> >>> Ok, I did not check this. Nevermind, then.
>> >>>
>> >>> Kind Regards, Thomas
>> >>>
>> >>> On Tue, Sep 29, 2015 at 4:25 PM, Daniel D. Daugherty <
>> >>> daniel.daugherty at oracle.com> wrote:
>> >>>
>> >>>> Ummm... VS2013 is the official compiler for JDK9 and Win*.
>> >>>> Why would we want to make a change to permit VS2010 to
>> >>>> continue to be used?
>> >>>>
>> >>>> Dan
>> >>>>
>> >>>>
>> >>>> On 9/29/15 7:58 AM, Thomas Stüfe wrote:
>> >>>>
>> >>>>> Hi all,
>> >>>>>
>> >>>>> please review this tiny change. It fixes the build on windows/Visual
>> >>>>> Studio
>> >>>>> 2010 after "8046148: JEP 158: Unified JVM Logging".
>> >>>>>
>> >>>>> strtoull() is missing from Visual Studio versions < 2013, but
>> >>>>> _strtoui64()
>> >>>>> can be used instead.
>> >>>>>
>> >>>>> webrev:
>> >>>>>
>> http://cr.openjdk.java.net/~stuefe/webrevs/8137329/webrev.00/webrev/
>> >>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8137329
>> >>>>>
>> >>>>> Thanks & Kind Regards, Thomas
>> >>>>>
>> >>>>
>> >
>>
>
>