RFR(M): 8139040: Fix initializations before ShouldNotReachHere()

[David Holmes]

Hi Goetz,

src/cpu/x86/vm/c1_LIRAssembler_x86.cpp

I'd prefer to see the missing initialization added to the default of the 
switch:

!   Assembler::Condition acond = Assembler::equal, ncond = 
Assembler::notEqual;
     switch (condition) {

otherwise we're just wasting instructions (or assuming the compiler will 
optimize it away).

Same with:

3189   Address::ScaleFactor scale = Address::no_scale;

More generally if something is complaining about an uninitialized 
variable on a ShouldNotReachHere/fatal path then put the initialization 
in that path, not the common code that will cause it to be unnecessarily 
executed.

Cheers,
David