RFR: 8129526: Solaris: clean up another remnant of interruptible I/O

David Holmes david.holmes at oracle.com
Thu Oct 29 22:20:43 UTC 2015


Thanks Dan!

David

On 29/10/2015 11:50 PM, Daniel D. Daugherty wrote:
> On 10/28/15 8:22 PM, David Holmes wrote:
>> bug: https://bugs.openjdk.java.net/browse/JDK-8129526
>> webrev: http://cr.openjdk.java.net/~dholmes/8129526/webrev/
>
> src/os/aix/vm/jvm_aix.cpp
>      No comments.
>
> src/os/aix/vm/jvm_aix.h
>      No comments.
>
> src/os/aix/vm/os_aix.cpp
>      No comments.
>
> src/os/bsd/vm/jvm_bsd.cpp
>      No comments.
>
> src/os/bsd/vm/jvm_bsd.h
>      No comments.
>
> src/os/bsd/vm/os_bsd.cpp
>      No comments.
>
> src/os/linux/vm/jvm_linux.cpp
>      No comments.
>
> src/os/linux/vm/jvm_linux.h
>      No comments.
>
> src/os/linux/vm/os_linux.cpp
>      No comments.
>
> src/os/solaris/vm/jvm_solaris.cpp
>      No comments.
>
> src/os/solaris/vm/jvm_solaris.h
>      No comments.
>
> src/os/solaris/vm/os_solaris.cpp
>      No comments.
>
> src/os/solaris/vm/os_solaris.hpp
>      No comments.
>
> src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp
>      No comments.
>
> src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp
>      No comments.
>
> Nice cleanup. Thumbs up.
>
> Dan
>
>
>>
>> Nothing but code deletion here :)
>>
>> Interruptible I/O was finally removed some time ago but we found a
>> remnant left over in the Solaris code in the use of SIGinterrupt. But
>> without interruptible I/O we don't need SIGinterrupt, nor its
>> cross-platform alter-ego INTERRUPT_SIGNAL. Some code related to
>> INTERRUPT_SIGNAL was copied from the Solaris code to the Linux code
>> (even though interruptible I/O never existed on linux) and it was
>> later copied from the Linux code to BSD and AIX. All of that has now
>> been cleaned up too - hence the cc to porters-dev to make sure the AIX
>> folk see this.
>>
>> Testing: JPRT
>>
>> Thanks,
>> David
>


More information about the hotspot-runtime-dev mailing list