RFR (M) round 3 8061999 Enhance VM option parsing to allow options to be specified

[Ron Durbin]

David,

 Thanks for your review, replies inline.


>-----Original Message-----
>From: David Holmes
>Sent: Thursday, September 03, 2015 10:16 PM
>To: Ron Durbin; hotspot-runtime-dev at openjdk.java.net
>Subject: Re: RFR (M) round 3 8061999 Enhance VM option parsing to allow options to be specified
>
>Hi Ron,
>
>On 4/09/2015 8:34 AM, Ron Durbin wrote:
>> Here is the round 3 webrev for 8061999.
>>
>> Here are the links to round 2 and 3 patch files.
>>
>> Round 2: : http://cr.openjdk.java.net/~rdurbin/8061999_OCR2_JDK9_webrev/hotspot.patch
>> Round 3: : http://cr.openjdk.java.net/~rdurbin/8061999_OCR3_JDK9_webrev/hotspot.patch
>>
>> Diff the patch files to see what changed in round 3.
>>
>>
>> Webrev link: http://cr.openjdk.java.net/~rdurbin/8061999_OCR3_JDK9_webrev
>
>3512   char *buf = NEW_C_HEAP_ARRAY(char, bytes_alloc, mtInternal);
>3513
>3514   if (NULL == buf) {
>
[Ron>] Changed allocator from NEW_C HEAP_ARRAY to NEW_C_HEAP_ARRAY_RETURN_NULL to allow local error handing.

>You will never get NULL as vm_exit_out_of_memory will be invoked if the
>underlying AllocateHeap fails. (IIRC someone pointed that out in a
>previous round.)
>
>3532     buf = NULL;
>
[Ron>] Removed
>Style nit: I don't see any point in NULL'ing a local when you are about
>to rerturn.
>
>Otherwise seems ok.
>
>Thanks,
>David
>
>> RFE link: https://bugs.openjdk.java.net/browse/JDK-8061999
>>
>> This RFE allows a file to be specified that holds VM Options that
>> would otherwise be specified on the command line or in an environment variable.
>> Only one options file may be specified on the command line and no options file
>> may be specified in either of the following environment variables
>> "JAVA_TOOL_OPTIONS" or "_JAVA_OPTIONS".
>>
>> The options file feature supports all VM options currently supported on
>> the command line, except the options file option. The option to specify an
>> options file is "-XX:VMOptionsFile=<Filename>".
>> The options file feature supports an options file up to 1024 bytes in size,
>>
>> This feature has been tested on:
>>    OS:
>>      Solaris, MAC, Windows, Linux
>>    Tests:
>>      Manual unit tests
>>      JPRT with -testset hotspot (including the SQE proposed test coverage for this feature.)
>>      Aurora,(Big Apps, JTREG,Tonga), Runtime SVC Nightly (in process)
>>