RFR (M) round 3 8061999 Enhance VM option parsing to allow options to be specified

[Ron Durbin]

Thanks for the review.


>-----Original Message-----
>From: Daniel D. Daugherty
>Sent: Thursday, September 03, 2015 4:44 PM
>To: Ron Durbin
>Cc: hotspot-runtime-dev at openjdk.java.net
>Subject: Re: RFR (M) round 3 8061999 Enhance VM option parsing to allow options to be specified
>
>On 9/3/15 4:34 PM, Ron Durbin wrote:
>> Here is the round 3 webrev for 8061999.
>>
>> Here are the links to round 2 and 3 patch files.
>>
>> Round 2: : http://cr.openjdk.java.net/~rdurbin/8061999_OCR2_JDK9_webrev/hotspot.patch
>> Round 3: : http://cr.openjdk.java.net/~rdurbin/8061999_OCR3_JDK9_webrev/hotspot.patch
>
>Thanks for the patch file links.
>
>
>> Diff the patch files to see what changed in round 3.
>>
>>
>> Webrev link: http://cr.openjdk.java.net/~rdurbin/8061999_OCR3_JDK9_webrev
>
>src/share/vm/runtime/arguments.hpp
>     No comments.
>
>src/share/vm/runtime/arguments.cpp
>     Thanks for moving "ScopedVMInitArgs vm_options_file_args"
>     higher in the call chain. That looks better than the strdup()
>     and free() calls.
>
>Thumbs up!
>
>Dan
>
>
>>
>> RFE link: https://bugs.openjdk.java.net/browse/JDK-8061999
>>
>> This RFE allows a file to be specified that holds VM Options that
>> would otherwise be specified on the command line or in an environment variable.
>> Only one options file may be specified on the command line and no options file
>> may be specified in either of the following environment variables
>> "JAVA_TOOL_OPTIONS" or "_JAVA_OPTIONS".
>>
>> The options file feature supports all VM options currently supported on
>> the command line, except the options file option. The option to specify an
>> options file is "-XX:VMOptionsFile=<Filename>".
>> The options file feature supports an options file up to 1024 bytes in size,
>>
>> This feature has been tested on:
>>    OS:
>>      Solaris, MAC, Windows, Linux
>>    Tests:
>>      Manual unit tests
>>      JPRT with -testset hotspot (including the SQE proposed test coverage for this feature.)
>>      Aurora,(Big Apps, JTREG,Tonga), Runtime SVC Nightly (in process)
>