RFR (M) 8135085: Change Method::_intrinsic_id from u1 to u2

Aleksey Shipilev aleksey.shipilev at oracle.com
Thu Sep 10 09:17:47 UTC 2015


On 09/09/2015 11:24 PM, Coleen Phillimore wrote:
> On 9/9/15 3:55 PM, Ioi Lam wrote:
>> On 9/9/15 11:36 AM, Aleksey Shipilev wrote:
>>> On 09/09/2015 08:37 PM, Coleen Phillimore wrote:
>> I just checked, there's no serviceability agent code that uses
>> intrinsic_id. So we're safe. No work to be done there :-)
>>
>> ./src/share/vm/runtime/vmStructs.cpp:  nonstatic_field(Method,
>> _intrinsic_id, u1)
>>
>> ~/jdk/jdk9_rt/hotspot/agent$ find . -name \*.java | xargs grep
>> intrinsic_id | wc
> 
> Thanks Ioi, I don't see it either.   Sometimes the name varies in the SA
> (different format/case, etc).
> 
> So I think the only thing that needs to be done is run this through some
> more testing.  I've looked at the change and it looks fine otherwise.
> 
> And please file the bug to fix the footprint on 32 bit.  This is
> important for those platforms.

Thanks Ioi and Coleen for following up on this! I'd appreciate if
somebody further pushed this patch through testing and sponsorship. Ioi,
can you take care about both _intrinsic_id and _method_size issues together?

Cheers,
-Aleksey




More information about the hotspot-runtime-dev mailing list