RFR(M): 8136525 Generate interpreter entries only once and avoid unnecessary jump to jump

Doerr, Martin martin.doerr at sap.com
Thu Sep 17 09:58:17 UTC 2015


Hi,

Thanks for the review.

Here's the new webrev (with an additional comment as requested by Coleen):
http://cr.openjdk.java.net/~mdoerr/8136525_interp_entries/webrev.01/

Thanks and best regards,
   Martin


-----Original Message-----
From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-bounces at openjdk.java.net] On Behalf Of Coleen Phillimore
Sent: Mittwoch, 16. September 2015 20:38
To: hotspot-runtime-dev at openjdk.java.net
Subject: Re: RFR(M): 8136525 Generate interpreter entries only once and avoid unnecessary jump to jump


This looks like a nice cleanup and I can sponsor it.

Can someone test this on aarch64?

http://cr.openjdk.java.net/~mdoerr/8136525_interp_entries/webrev.00/src/share/vm/interpreter/interpreter.cpp.html

Can you add a comment before 603 that you are reusing native or normal 
entry point addresses so you assume that they are generated first.

Coleen

On 9/16/15 4:44 AM, Doerr, Martin wrote:
> Hi,
>
> I improved the interpreter entries by avoiding multiple generation of the normal and native entries as well as entries which just jump to one of them.
> Please note that I didn't test it on aarch64.
>
> Please review this change.  I please need a sponsor.
> http://cr.openjdk.java.net/~mdoerr/8136525_interp_entries/webrev.00/
>
> Best regards,
>    Martin
>



More information about the hotspot-runtime-dev mailing list