RFR(XS) 8132904: Type checking verifier fails to reject assignment from array to an interface

[harold seigel]

Thanks again!

Harold

On 9/17/2015 3:32 PM, Keith McGuigan wrote:
> LGTM. Thanks!
>
> --
> - Keith
>
> On Thu, Sep 17, 2015 at 3:30 PM, harold seigel 
> <harold.seigel at oracle.com <mailto:harold.seigel at oracle.com>> wrote:
>
>     Hi,
>
>     I updated the comment and regenerated the webrev.
>
>     Please let me know if it still needs work.
>
>     Thanks, Harold
>
>     On 9/17/2015 2:28 PM, Keith McGuigan wrote:
>>     Looks good, though I would update the comment above your fix to
>>     more accurately describe what is going on now.
>>
>>     --
>>     - Keith
>>
>>     On Thu, Sep 17, 2015 at 2:03 PM, harold seigel
>>     <harold.seigel at oracle.com <mailto:harold.seigel at oracle.com>> wrote:
>>
>>         Hi,
>>
>>         Please review this small change to fix bug 8132904.  The new
>>         verifier implementation in HotSpot should not allow an
>>         arbitrary array type to be assignable to an arbitrary
>>         interface type.  The special cases of Cloneable, and
>>         Serializable are clearly called out in the spec.  This fix
>>         disallows assignability of an array to interface type unless
>>         it's one of the Cloneable or Serializable special cases.
>>
>>         Open webrev: http://cr.openjdk.java.net/~hseigel/bug_8132904/
>>         <http://cr.openjdk.java.net/%7Ehseigel/bug_8132904/>
>>
>>         JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8132904
>>
>>         The fix was tested with JCK Lang, VM, and API java_lang
>>         tests, the UTE quick and split verifier tests, and the
>>         hotspot, JDK vm, java/io, java/lang, and java/util JTreg
>>         tests, the JCK tests that are currently excluded because of
>>         this bug, and the test case in the bug report.
>>
>>         This scenario will be tested by JCK-9.  So there's no
>>         regression test in this webrev.
>>
>>         Thanks, Harold
>>
>>
>>
>>
>>     -- 
>>
>>     twitter-icon-large.png
>>
>>     	
>>
>>     Keith McGuigan
>>
>>     @kamggg
>>
>>     <mailto:kmcguigan at twitter.com>kmcguigan at twitter.com
>>     <mailto:kmcguigan at twitter.com>
>>
>
>
>
>
> -- 
>
> twitter-icon-large.png
>
> 	
>
> Keith McGuigan
>
> @kamggg
>
> kmcguigan at twitter.com <mailto:kmcguigan at twitter.com>
>