RFR - JDK-8134432: [TESTBUG] Rewrite test/runtime/6888954/vmerrors.sh in Java
Dmitry Dmitriev
dmitry.dmitriev at oracle.com
Mon Sep 28 13:43:22 UTC 2015
Hi George,
For test cases 2, 4 and 6 you expect to see "num=4096" in the
output(lines 48, 50, 52). As I see from
src/share/vm/utilities/debug.cpp, 'num' in this case is equal to the
'vm_page_size'.
Probably will be better not use hard coded value(4096) in the test and
use pattern for that string? Or use "getVMPageSize" white box method to
get page size value?
Otherwise looks good!
Thanks,
Dmitry
On 25.09.2015 18:05, George Triantafillou wrote:
> Please review this fix for JDK-8134432:
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8134432
> webrev: http://cr.openjdk.java.net/~gtriantafill/8134432/webrev.00/
> <http://cr.openjdk.java.net/%7Egtriantafill/8134432/webrev.00/>
>
> The test was rewritten in Java, and two previously missing test cases
> were added to the test.
>
> The fix was tested with RBT on all platforms with the JPRT hotspot_all
> testset. Thanks.
>
> -George
More information about the hotspot-runtime-dev
mailing list