RFR (S) round 1 for 8135195 VM Options file should not be limited to 1024 bytes

Dmitry Dmitriev dmitry.dmitriev at oracle.com
Tue Sep 29 15:05:12 UTC 2015


Hello Ron,

File descriptor leak is possible if os::stat failed or if file size is 
equal to 0. Therefore os::close should be added to the 'if' statements 
on lines 3508 and 3515.

Thanks,
Dmitry

On 29.09.2015 17:29, Ron Durbin wrote:
> Here is the round 1 webrev for 8135195
> This latest version of the fix is much simpler than the previous version so no delta webrev is provided.
>
> Webrev link:
> http://cr.openjdk.java.net/~rdurbin/8135195_OCR1_JDK9_webrev/
>
> RFE request:
> https://bugs.openjdk.java.net/browse/JDK-8135195
>
> This RFE removes the limitation on the size of VM Options files. That
> limit is currently 1K bytes.
> Removing that limit will allow options files to be read with no
> practical size limit.
>
> This feature has been tested on:
>       OS:
>         Solaris, MAC, Windows, Linux
>       Tests:
>         Manual unit test
>       JPRT with -testset hotspot (including the SQE proposed test
>       coverage for this feature.)



More information about the hotspot-runtime-dev mailing list