RFR(xxs): [windows] Build broken on VS2010 after "8046148: JEP 158: Unified JVM Logging"

[Lindenmaier, Goetz]

Hi,

We are consuming openJDK and appreciate if it builds with older compilers.
And probably there are others out there that will run into the same problem.
So I would appreciate if this finds a majority and gets pushed.

Thanks and best regards,
  Goetz.


-----Original Message-----
From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-bounces at openjdk.java.net] On Behalf Of Daniel D. Daugherty
Sent: Tuesday, September 29, 2015 4:25 PM
To: Thomas Stüfe <thomas.stuefe at gmail.com>; hotspot-runtime-dev at openjdk.java.net
Subject: Re: RFR(xxs): [windows] Build broken on VS2010 after "8046148: JEP 158: Unified JVM Logging"

Ummm... VS2013 is the official compiler for JDK9 and Win*.
Why would we want to make a change to permit VS2010 to
continue to be used?

Dan

On 9/29/15 7:58 AM, Thomas Stüfe wrote:
> Hi all,
>
> please review this tiny change. It fixes the build on windows/Visual Studio
> 2010 after "8046148: JEP 158: Unified JVM Logging".
>
> strtoull() is missing from Visual Studio versions < 2013, but _strtoui64()
> can be used instead.
>
> webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8137329/webrev.00/webrev/
> bug: https://bugs.openjdk.java.net/browse/JDK-8137329
>
> Thanks & Kind Regards, Thomas