RFR: JDK-8138574: [TESTBUG] TestBasicLogOutput.java doesn't account for padding

Dmitry Dmitriev dmitry.dmitriev at oracle.com
Tue Sep 29 20:51:00 UTC 2015


Hello Rachel,

Another approach is to use shouldMatch(String pattern) OutputAnalyzer 
method and provide following pattern to it:"\\[logging *\\]"
In this case we check that tag is exactly "logging", i.e. without junk 
characters at the end.

Thanks,
Dmitry

On 29.09.2015 20:34, Rachel Protacio wrote:
> Hello! Please review this one-character change to fix bug 8138574, 
> where the existing test was not general enough to pass as new logging 
> tags are added.
>
> Summary: TestBasicLogOutput.java edited to account for padding in tag 
> descriptors
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8138574
> Webrev: http://cr.openjdk.java.net/~coleenp/8138574
>
> Testing: passes jtreg on own and when tested with added tags
>
> Thank you,
> Rachel



More information about the hotspot-runtime-dev mailing list