RFR (S) round 1 for 8135195 VM Options file should not be limited to 1024 bytes

Daniel D. Daugherty daniel.daugherty at oracle.com
Tue Sep 29 22:39:17 UTC 2015


On 9/29/15 8:29 AM, Ron Durbin wrote:
> Here is the round 1 webrev for 8135195
> This latest version of the fix is much simpler than the previous version so no delta webrev is provided.
>
> Webrev link:
> http://cr.openjdk.java.net/~rdurbin/8135195_OCR1_JDK9_webrev/

In addition to what Dmitry pointed out about the missing close() calls:

src/share/vm/runtime/arguments.cpp
     L3510:                 "Could not stat options file %s'\n",
         Missing a single quote before the %s.

Dan


>
> RFE request:
> https://bugs.openjdk.java.net/browse/JDK-8135195
>
> This RFE removes the limitation on the size of VM Options files. That
> limit is currently 1K bytes.
> Removing that limit will allow options files to be read with no
> practical size limit.
>
> This feature has been tested on:
>       OS:
>         Solaris, MAC, Windows, Linux
>       Tests:
>         Manual unit test
>       JPRT with -testset hotspot (including the SQE proposed test
>       coverage for this feature.)
>



More information about the hotspot-runtime-dev mailing list